Re: [PATCH] powerpc: fix debugfs_create_dir error checking
From: Greg KH <gregkh@linuxfoundation.org>
Date: 2023-05-28 07:57:10
Also in:
lkml
On Sun, May 28, 2023 at 01:16:44PM +0530, mirimmad@outlook.com wrote:
quoted hunk ↗ jump to hunk
From: Immad Mir <redacted> The debugfs_create_dir returns ERR_PTR incase of an error and the correct way of checking it by using the IS_ERR inline function, and not the simple null comparision. This patch fixes this. Suggested-By: Ivan Orlov <ivan.orlov0322@gmail.com> Signed-off-by: Immad Mir <redacted> --- arch/powerpc/platforms/powernv/opal-xscom.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)diff --git a/arch/powerpc/platforms/powernv/opal-xscom.c b/arch/powerpc/platforms/powernv/opal-xscom.c index 6b4eed2ef..262cd6fac 100644 --- a/arch/powerpc/platforms/powernv/opal-xscom.c +++ b/arch/powerpc/platforms/powernv/opal-xscom.c@@ -168,7 +168,7 @@ static int scom_debug_init_one(struct dentry *root, struct device_node *dn, ent->path.size = strlen((char *)ent->path.data); dir = debugfs_create_dir(ent->name, root); - if (!dir) { + if (IS_ERR(dir)) { kfree(ent->path.data); kfree(ent); return -1;
Why is this driver caring if debugfs is working or not at all? It should just ignore the error and keep moving forward. And -1 is not a valid error number :( Have you hit this error on this driver? thanks, greg k-h