Re: [PATCH 10/14] suspend: add a arch_resume_nosmt() prototype
From: "Rafael J. Wysocki" <rafael@kernel.org>
Date: 2023-05-24 17:33:23
Also in:
linux-arm-kernel, linux-kselftest, linux-mips, linux-mm, linux-pm, linux-riscv, linux-s390, linux-sh, lkml
On Wed, May 17, 2023 at 4:52 PM Arnd Bergmann [off-list ref] wrote:
On Wed, May 17, 2023, at 15:48, Rafael J. Wysocki wrote:quoted
On Wed, May 17, 2023 at 3:12 PM Arnd Bergmann [off-list ref] wrote:quoted
From: Arnd Bergmann <arnd@arndb.de> The arch_resume_nosmt() has a __weak definition, plus an x86 specific override, but no prototype that ensures the two have the same arguments. This causes a W=1 warning: arch/x86/power/hibernate.c:189:5: error: no previous prototype for 'arch_resume_nosmt' [-Werror=missing-prototypes] Add the prototype in linux/suspend.h, which is included in both places. Signed-off-by: Arnd Bergmann <arnd@arndb.de>Do you want me to pick this up?Yes, please do. Thanks,
Done, thanks!