Re: [PATCH] net: Use of_property_read_bool() for boolean properties

From
Simon Horman <hidden>
Date
2023-03-15 08:35:25
Also in
linux-can, linux-devicetree, linux-omap, linux-wireless, lkml, netdev
Reply to
Rob Herring, 2023-03-14
On Tue, Mar 14, 2023 at 02:14:37PM -0500, Rob Herring wrote:
On Sat, Mar 11, 2023 at 5:50 AM Simon Horman [off-list ref] wrote:
quoted
On Fri, Mar 10, 2023 at 08:47:16AM -0600, Rob Herring wrote:
quoted
It is preferred to use typed property access functions (i.e.
of_property_read_<type> functions) rather than low-level
of_get_property/of_find_property functions for reading properties.
Convert reading boolean properties to to of_property_read_bool().

Signed-off-by: Rob Herring <robh@kernel.org>
Reviewed-by: Simon Horman <redacted>

...
quoted
diff --git a/drivers/net/ethernet/via/via-velocity.c b/drivers/net/ethernet/via/via-velocity.c
index a502812ac418..86f7843b4591 100644
--- a/drivers/net/ethernet/via/via-velocity.c
+++ b/drivers/net/ethernet/via/via-velocity.c
@@ -2709,8 +2709,7 @@ static int velocity_get_platform_info(struct velocity_info *vptr)
      struct resource res;
      int ret;

-     if (of_get_property(vptr->dev->of_node, "no-eeprom", NULL))
-             vptr->no_eeprom = 1;
+     vptr->no_eeprom = of_property_read_bool(vptr->dev->of_node, "no-eeprom");
As per my comment on "[PATCH] nfc: mrvl: Use of_property_read_bool() for
boolean properties".

I'm not that enthusiastic about assigning a bool value to a field
with an integer type. But that is likely a topic for another patch.
quoted
      ret = of_address_to_resource(vptr->dev->of_node, 0, &res);
      if (ret) {
...
quoted
diff --git a/drivers/net/wan/fsl_ucc_hdlc.c b/drivers/net/wan/fsl_ucc_hdlc.c
index 1c53b5546927..47c2ad7a3e42 100644
--- a/drivers/net/wan/fsl_ucc_hdlc.c
+++ b/drivers/net/wan/fsl_ucc_hdlc.c
@@ -1177,14 +1177,9 @@ static int ucc_hdlc_probe(struct platform_device *pdev)
      uhdlc_priv->dev = &pdev->dev;
      uhdlc_priv->ut_info = ut_info;

-     if (of_get_property(np, "fsl,tdm-interface", NULL))
-             uhdlc_priv->tsa = 1;
-
-     if (of_get_property(np, "fsl,ucc-internal-loopback", NULL))
-             uhdlc_priv->loopback = 1;
-
-     if (of_get_property(np, "fsl,hdlc-bus", NULL))
-             uhdlc_priv->hdlc_bus = 1;
+     uhdlc_priv->tsa = of_property_read_bool(np, "fsl,tdm-interface");
Here too.
These are already bool.
Sorry, I thought I checked. But clearly I messed it up somehow.
Turns out the only one that needs changing is
no_eeprom. netdev folks marked this as changes requested, so I'll add
that in v2.
Thanks.
Thread (7 messages) 7 messages, 5 authors, last reply 2023-03-15
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help