Thread (7 messages) 7 messages, 4 authors, 2023-03-23

Re: [PATCH v3 01/38] Kconfig: introduce HAS_IOPORT option and select it as necessary

From: Johannes Berg <johannes@sipsolutions.net>
Date: 2023-03-14 12:40:51
Also in: linux-alpha, linux-arch, linux-m68k, linux-mips, linux-pci, linux-riscv, linux-sh, linux-um, lkml, sparclinux

On Tue, 2023-03-14 at 13:11 +0100, Niklas Schnelle wrote:
quoted hunk ↗ jump to hunk
--- a/arch/um/Kconfig
+++ b/arch/um/Kconfig
@@ -56,6 +56,7 @@ config NO_IOPORT_MAP
 
 config ISA
 	bool
+	depends on HAS_IOPORT
config ISA here is already unselectable, and nothing ever does "select
ISA" (only in some other architectures), so is there much point in this?

I'm not even sure why this exists at all.

But anyway, adding a dependency to a always-false symbol doesn't make it
less always-false :-)

Acked-by: Johannes Berg <johannes@sipsolutions.net> # for ARCH=um


Certainly will be nice to get rid of this cruft for architectures that
don't have it.

johannes
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help