Re: [PATCH v4 3/4] arch/*/io.h: remove ioremap_uc in some architectures
From: Helge Deller <deller@gmx.de>
Date: 2023-03-10 21:14:45
Also in:
linux-alpha, linux-arch, linux-m68k, linux-mips, linux-mm, linux-sh, lkml, sparclinux
On 3/10/23 02:45, Baoquan He wrote:
On 03/09/23 at 03:36pm, Thomas Bogendoerfer wrote:quoted
On Wed, Mar 08, 2023 at 09:07:09PM +0800, Baoquan He wrote:quoted
ioremap_uc() is only meaningful on old x86-32 systems with the PAT extension, and on ia64 with its slightly unconventional ioremap() behavior. So remove the ioremap_uc() definition in architecutures other than x86 and ia64. These architectures all have asm-generic/io.h included and will have the default ioremap_uc() definition which returns NULL. This changes the existing behaviour, while no need to worry about any breakage because in the only callsite of ioremap_uc(), code has been adjusted to eliminate the impact. Please see atyfb_setup_generic() of drivers/video/fbdev/aty/atyfb_base.c. If any new invocation of ioremap_uc() need be added, please consider using ioremap() intead or adding a ARCH specific version if necessary. Acked-by: Geert Uytterhoeven <geert@linux-m68k.org> Signed-off-by: Baoquan He <redacted> Cc: linux-alpha@vger.kernel.org Cc: linux-hexagon@vger.kernel.org Cc: linux-m68k@lists.linux-m68k.org Cc: linux-mips@vger.kernel.org Cc: linux-parisc@vger.kernel.org Cc: linuxppc-dev@lists.ozlabs.org Cc: linux-sh@vger.kernel.org Cc: sparclinux@vger.kernel.org --- Documentation/driver-api/device-io.rst | 9 +++++---- arch/alpha/include/asm/io.h | 1 - arch/hexagon/include/asm/io.h | 3 --- arch/m68k/include/asm/kmap.h | 1 - arch/mips/include/asm/io.h | 1 - arch/parisc/include/asm/io.h | 2 -- arch/powerpc/include/asm/io.h | 1 - arch/sh/include/asm/io.h | 2 -- arch/sparc/include/asm/io_64.h | 1 - 9 files changed, 5 insertions(+), 16 deletions(-)this doesn't apply to v6.3-rc1... what tree is this based on ?Sorry, I forgot mentioning this in cover letter. This series is followup of below patchset, so it's on top of below patchset and based on v6.3-rc1. https://lore.kernel.org/all/20230301034247.136007-1-bhe@redhat.com/T/#u (local) [PATCH v5 00/17] mm: ioremap: Convert architectures to take GENERIC_IOREMAP way
I've applied both patch series on top of v6.3-rc1 and tested it with success on the parisc platform (32- and 64-bit kernel). You may add to both patch series: Acked-by: Helge Deller <deller@gmx.de> # parisc Thank you! Helge