Thread (22 messages) 22 messages, 3 authors, 2023-03-06

Re: [PATCH v6 01/10] dt-bindings: soc: fsl: cpm_qe: Add TSA controller

From: Herve Codina <herve.codina@bootlin.com>
Date: 2023-03-06 15:42:58
Also in: alsa-devel, linux-arm-kernel, linux-devicetree, lkml

Hi Rob,
On Sun, 26 Feb 2023 11:48:33 -0600
Rob Herring [off-list ref] wrote:

[...]
quoted
+  '#size-cells':
+    const: 0
+
+  '#fsl,serial-cells':  
#foo-cells is for when there are differing foo providers which need 
different number of cells. That's not the case here.
Ok, I will remove the #fsl,serial-cells property on the next iteration.

On the next series iteration, I will also remove the #fsl,chan-cells property
present later on a patch related to the QMC binding. The #fsl,chan-cells needs
to be removed exactly for the same reason.
quoted
+    $ref: /schemas/types.yaml#/definitions/uint32
+    const: 1
+    description:
+      TSA consumers that use a phandle to TSA need to pass the serial identifier
+      with this phandle (defined in dt-bindings/soc/fsl,tsa.h).
+      For instance "fsl,tsa-serial = <&tsa FSL_CPM_TSA_SCC4>;".  
Thanks for the review.
Hervé
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help