Re: [PATCH 3/3] of: irq: release the node after looking up for "interrupts-extended"
From: Rob Herring <robh+dt@kernel.org>
Date: 2023-03-01 21:01:08
Also in:
linux-arm-kernel, linux-devicetree, linux-pci, linux-renesas-soc, linux-riscv, linux-sunxi, linux-tegra, linux-usb, linux-wireless, lkml
On Wed, Mar 1, 2023 at 12:53 PM Jean-Jacques Hiblot [off-list ref] wrote:
When of_parse_phandle_with_args() succeeds, a get() is performed on out_irq->np. And another get() is performed in of_irq_parse_raw(), resulting in the refcount being incremented twice. Fixing this by calling put() after of_irq_parse_raw().
This looks like a band-aid to me. It only makes sense that the caller
of of_irq_parse_raw() already holds a ref to out_irq->np. So the first
of_node_get() in it looks wrong. It looks like the refcounting was
originally balanced, but commit 2f53a713c4b6 ("of/irq: Fix device_node
refcount in of_irq_parse_raw()") dropped the put on exit after 'got
it!'. I'm not sure if just adding it back would be correct or not
though.
All this needs some test cases to be sure we get things right...
Rob