Re: [PATCH] powerpc/64: Fix unannotated intra-function call warning
From: Stephen Rothwell <hidden>
Date: 2023-02-17 05:33:56
Hi all, On Fri, 17 Feb 2023 10:02:26 +0530 Sathvika Vasireddy [off-list ref] wrote:
quoted hunk ↗ jump to hunk
objtool throws the following warning: arch/powerpc/kernel/head_64.o: warning: objtool: .text+0x6128: unannotated intra-function call Fix the warning by annotating start_initialization_book3s symbol with the SYM_FUNC_START_LOCAL and SYM_FUNC_END macros. Reported-by: Stephen Rothwell <redacted> Signed-off-by: Sathvika Vasireddy <redacted> --- arch/powerpc/kernel/head_64.S | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)diff --git a/arch/powerpc/kernel/head_64.S b/arch/powerpc/kernel/head_64.S index 3a7266fa8a18..1febb56ebaeb 100644 --- a/arch/powerpc/kernel/head_64.S +++ b/arch/powerpc/kernel/head_64.S@@ -472,7 +472,7 @@ SYM_FUNC_START_LOCAL(__mmu_off) b . /* prevent speculative execution */ SYM_FUNC_END(__mmu_off) -start_initialization_book3s: +SYM_FUNC_START_LOCAL(start_initialization_book3s) mflr r25 /* Setup some critical 970 SPRs before switching MMU off */@@ -494,6 +494,7 @@ start_initialization_book3s: mtlr r25 blr +SYM_FUNC_END(start_initialization_book3s) #endif /*-- 2.31.1
That at least makes the warning go away for me.
Tested-by: Stephen Rothwell <redacted>
Fixes: 58f24eea5278 ("powerpc/64s: Refactor initialisation after prom")
--
Cheers,
Stephen Rothwell Attachments
- (unnamed) [application/pgp-signature] 488 bytes