Re: [PATCH] macintosh: via-pmu-led: *********************************
From: Michael Ellerman <mpe@ellerman.id.au>
Date: 2023-02-23 08:56:45
Also in:
lkml
Randy Dunlap [off-list ref] writes:
LEDS_TRIGGER_DISK depends on ATA, so selecting LEDS_TRIGGER_DISK when ATA is not set/enabled causes a Kconfig warning: WARNING: unmet direct dependencies detected for LEDS_TRIGGER_DISK Depends on [n]: NEW_LEDS [=y] && LEDS_TRIGGERS [=y] && ATA [=n] Selected by [y]: - ADB_PMU_LED_DISK [=y] && MACINTOSH_DRIVERS [=y] && ADB_PMU_LED [=y] && LEDS_CLASS [=y] Fix this by making ADB_PMU_LED_DISK depend on ATA.
Should it just depend on LEDS_TRIGGER_DISK ? cheers
quoted hunk ↗ jump to hunk
Seen on both PPC32 and PPC64. Fixes: 0e865a80c135 ("macintosh: Remove dependency on IDE_GD_ATA if ADB_PMU_LED_DISK is selected") Signed-off-by: Randy Dunlap <redacted> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org> Cc: Paul Mackerras <redacted> Cc: Elimar Riesebieter <redacted> Cc: Michael Ellerman <mpe@ellerman.id.au> Cc: linuxppc-dev@lists.ozlabs.org --- drivers/macintosh/Kconfig | 1 + 1 file changed, 1 insertion(+) diff -- a/drivers/macintosh/Kconfig b/drivers/macintosh/Kconfig--- a/drivers/macintosh/Kconfig +++ b/drivers/macintosh/Kconfig@@ -86,6 +86,7 @@ config ADB_PMU_LED config ADB_PMU_LED_DISK bool "Use front LED as DISK LED by default" + depends on ATA depends on ADB_PMU_LED depends on LEDS_CLASS select LEDS_TRIGGERS