Thread (25 messages) flat view 25 messages, 2 authors, 2023-02-15

Re: [PATCH v2 3/8] powerpc/85xx: p2020: Move all P2020 machine descriptions to p2020.c

From: Christophe Leroy <hidden>
Date: 2023-02-14 05:49:31
Also in: lkml


Le 13/02/2023 à 21:15, Pali Rohár a écrit :
On Monday 13 February 2023 20:05:09 Christophe Leroy wrote:
quoted
Le 24/12/2022 à 22:14, Pali Rohár a écrit :
quoted
+#ifdef CONFIG_MPC85xx_RDB
+static void __init mpc85xx_rdb_pic_init(void)
+{
+	struct mpic *mpic;
+
+	mpic = mpic_alloc(NULL, 0,
+	  MPIC_BIG_ENDIAN |
+	  MPIC_SINGLE_DEST_CPU,
+	  0, 256, " OpenPIC  ");
Can you make it a single line ? At least no more than two lines ?
All these lines are already present in kernel tree.
So it could be fixed in separate patch.

If needed I can do it as part of this series in new patch.
Well, that goes away in patch 5. So it is not really worth it.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help