Re: [PATCH v2] powerpc: macio: Make remove callback of macio driver void returned
From: Michael Ellerman <mpe@ellerman.id.au>
Date: 2023-01-30 04:48:15
Also in:
lkml
Dawei Li [off-list ref] writes:
Commit fc7a6209d571 ("bus: Make remove callback return void") forces
bus_type::remove be void-returned, it doesn't make much sense for any
bus based driver implementing remove callbalk to return non-void to
its caller.
This change is for macio bus based drivers.
Signed-off-by: Dawei Li <redacted>
---
v1 -> v2
- Revert unneeded changes.
- Rebased on latest powerpc/next.
v1
- https://lore.kernel.org/all/TYCP286MB2323FCDC7ECD87F8D97CB74BCA189@TYCP286MB2323.JPNP286.PROD.OUTLOOK.COM/ (local)
---
arch/powerpc/include/asm/macio.h | 2 +-
drivers/ata/pata_macio.c | 4 +---
drivers/macintosh/rack-meter.c | 4 +---
drivers/net/ethernet/apple/bmac.c | 4 +---
drivers/net/ethernet/apple/mace.c | 4 +---
drivers/net/wireless/intersil/orinoco/airport.c | 4 +---
drivers/scsi/mac53c94.c | 5 +----
drivers/scsi/mesh.c | 5 +----
drivers/tty/serial/pmac_zilog.c | 7 ++-----
sound/aoa/soundbus/i2sbus/core.c | 4 +---
10 files changed, 11 insertions(+), 32 deletions(-)I realise the patch has to be merged via a single subsystem, and powerpc is probably the most appropriate, but please Cc the relevant lists for the drivers touched. AFAICS neither this version or v1 was Cc'ed to relevant lists, eg. netdev, linux-wireless, linux-scsi, alsa-devel etc. cheers