Thread (17 messages) 17 messages, 3 authors, 2023-01-25

Re: [PATCH v3 01/11] perf jevents metric: Correct Function equality

From: kajoljain <hidden>
Date: 2023-01-25 04:56:40
Also in: linux-arm-kernel, linux-perf-users, lkml


On 1/24/23 12:03, Ian Rogers wrote:
quoted hunk ↗ jump to hunk
rhs may not be defined, say for source_count, so add a guard.

Signed-off-by: Ian Rogers <irogers@google.com>
---
 tools/perf/pmu-events/metric.py | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/tools/perf/pmu-events/metric.py b/tools/perf/pmu-events/metric.py
index 4797ed4fd817..2f2fd220e843 100644
--- a/tools/perf/pmu-events/metric.py
+++ b/tools/perf/pmu-events/metric.py
@@ -261,8 +261,10 @@ class Function(Expression):
 
   def Equals(self, other: Expression) -> bool:
     if isinstance(other, Function):
-      return self.fn == other.fn and self.lhs.Equals(
-          other.lhs) and self.rhs.Equals(other.rhs)
+      result = self.fn == other.fn and self.lhs.Equals(other.lhs)
+      if self.rhs:
+        result = result and self.rhs.Equals(other.rhs)
+      return result
     return False
 
 
Patch looks good to me.

Reviewed-by: Kajol Jain<redacted>

Thanks,
Kajol Jain
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help