Thread (20 messages) 20 messages, 7 authors, 2023-01-19

Re: [PATCH 05/11] ARM: dts: socfpga: Fix pca9548 i2c-mux node name

From: Dinh Nguyen <dinguyen@kernel.org>
Date: 2022-12-06 21:02:03
Also in: linux-arm-kernel, linux-aspeed, linux-devicetree, linux-mips, linux-omap, linux-renesas-soc


On 12/2/22 10:49, Geert Uytterhoeven wrote:
quoted hunk ↗ jump to hunk
"make dtbs_check":

     arch/arm/boot/dts/socfpga_cyclone5_vining_fpga.dtb: i2cswitch@70: $nodename:0: 'i2cswitch@70' does not match '^(i2c-?)?mux'
	    From schema: Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.yaml
     arch/arm/boot/dts/socfpga_cyclone5_vining_fpga.dtb: i2cswitch@70: Unevaluated properties are not allowed ('#address-cells', '#size-cells', 'i2c@0', 'i2c@1', 'i2c@2', 'i2c@3', 'i2c@4', 'i2c@5', 'i2c@6', 'i2c@7' were unexpected)
         From schema: Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.yaml

Fix this by renaming the PCA9548 node to "i2c-mux", to match the I2C bus
multiplexer/switch DT bindings and the Generic Names Recommendation in
the Devicetree Specification.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
  arch/arm/boot/dts/socfpga_cyclone5_vining_fpga.dts | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/socfpga_cyclone5_vining_fpga.dts b/arch/arm/boot/dts/socfpga_cyclone5_vining_fpga.dts
index f24f17c2f5ee6bc4..e0630b0eed036d35 100644
--- a/arch/arm/boot/dts/socfpga_cyclone5_vining_fpga.dts
+++ b/arch/arm/boot/dts/socfpga_cyclone5_vining_fpga.dts
@@ -141,7 +141,7 @@ at24@50 {
  		reg = <0x50>;
  	};
  
-	i2cswitch@70 {
+	i2c-mux@70 {
  		compatible = "nxp,pca9548";
  		#address-cells = <1>;
  		#size-cells = <0>;
Applied!

Thanks,
Dinh
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help