Thread (12 messages) 12 messages, 5 authors, 2022-12-09

Re: [PATCH v8 3/3] ASoC: SOF: Fix deadlock when shutdown a frozen userspace

From: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Date: 2022-12-09 11:54:11
Also in: kexec, linux-efi, linux-hyperv, linux-pci, linux-pm, lkml, stable, xen-devel

Hi,

On Thu, 1 Dec 2022, Ricardo Ribalda wrote:
On Thu, 1 Dec 2022 at 14:22, 'Oliver Neukum' via Chromeos Kdump [off-list ref] wrote:
quoted
On 01.12.22 14:03, Ricardo Ribalda wrote:
quoted
This patchset does not modify this behaviour. It simply fixes the
stall for kexec().

The  patch that introduced the stall:
83bfc7e793b5 ("ASoC: SOF: core: unregister clients and machine drivers
in .shutdown")
That patch is problematic. I would go as far as saying that
it needs to be reverted.
It fixes a real issue. We have not had any complaints until we tried
to kexec in the platform.
I wont recommend reverting it until we have an alternative implementation.

kexec is far less common than suspend/reboot.
I've posted an alternative to ALSA list that reverts the problematic
patch and fixes the problem (the patch was originally addressing)
in a different way:

https://mailman.alsa-project.org/pipermail/alsa-devel/2022-December/209776.html

No changes outside sound/soc/ are needed with this approach.

Br, Kai
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help