Re: [PATCH 5/5] powerpc: dts: remove label = "cpu" from DSA dt-binding
From: Michael Ellerman <mpe@ellerman.id.au>
Date: 2022-12-01 10:40:12
Also in:
linux-devicetree, lkml, netdev
Arınç ÜNAL [off-list ref] writes:
This is not used by the DSA dt-binding, so remove it from all devicetrees. Signed-off-by: Arınç ÜNAL <redacted> --- arch/powerpc/boot/dts/turris1x.dts | 2 -- 1 file changed, 2 deletions(-)
Adding Pali to Cc.
These were only recently updated in commit:
8bf056f57f1d ("powerpc: dts: turris1x.dts: Fix labels in DSA cpu port nodes")
Which said:
DSA cpu port node has to be marked with "cpu" label.
But if the binding doesn't use them then I'm confused why they needed to
be updated.
cheers
quoted hunk ↗ jump to hunk
diff --git a/arch/powerpc/boot/dts/turris1x.dts b/arch/powerpc/boot/dts/turris1x.dts index 045af668e928..3841c8d96d00 100644 --- a/arch/powerpc/boot/dts/turris1x.dts +++ b/arch/powerpc/boot/dts/turris1x.dts@@ -147,7 +147,6 @@ ports { port@0 { reg = <0>; - label = "cpu"; ethernet = <&enet1>; phy-mode = "rgmii-id";@@ -184,7 +183,6 @@ port@5 { port@6 { reg = <6>; - label = "cpu"; ethernet = <&enet0>; phy-mode = "rgmii-id";-- 2.34.1