Thread (49 messages) 49 messages, 7 authors, 2022-11-03

Re: [PATCH] asm-generic: compat: fix compat_arg_u64 and compat_arg_u64_dual

From: Christophe Leroy <hidden>
Date: 2022-11-03 08:21:48


Le 31/10/2022 à 14:23, Andreas Schwab a écrit :
quoted hunk ↗ jump to hunk
The macros are defined backwards.

Fixes: 43d5de2b67d7 ("asm-generic: compat: Support BE for long long args in 32-bit ABIs")
Signed-off-by: Andreas Schwab <redacted>
---
  include/asm-generic/compat.h | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/asm-generic/compat.h b/include/asm-generic/compat.h
index aeb257ad3d1a..8392caea398f 100644
--- a/include/asm-generic/compat.h
+++ b/include/asm-generic/compat.h
@@ -15,7 +15,7 @@
  #endif
  
  #ifndef compat_arg_u64
-#ifdef CONFIG_CPU_BIG_ENDIAN
+#ifndef CONFIG_CPU_BIG_ENDIAN
Could be CONFIG_CPU_LITTLE_ENDIAN then ?
  #define compat_arg_u64(name)		u32  name##_lo, u32  name##_hi
  #define compat_arg_u64_dual(name)	u32, name##_lo, u32, name##_hi
  #else
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help