Thread (4 messages) 4 messages, 2 authors, 2022-11-29

Re: [PATCH] driver core: fix up some missing class.devnode() conversions.

From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Date: 2022-11-29 08:28:39
Also in: lkml

On Tue, Nov 29, 2022 at 06:33:04AM +0000, Christophe Leroy wrote:

Le 28/11/2022 à 18:35, Greg Kroah-Hartman a écrit :
quoted
In commit ff62b8e6588f ("driver core: make struct class.devnode() take a
const *") the ->devnode callback changed the pointer to be const, but a
few instances of PowerPC drivers were not caught for some reason.

Fix this up by changing the pointers to be const.
Build fails:

/linux/arch/powerpc/platforms/book3s/vas-api.c: In function 
'vas_register_coproc_api':
/linux/arch/powerpc/platforms/book3s/vas-api.c:590:31: error: assignment 
from incompatible pointer type [-Werror=incompatible-pointer-types]
   coproc_device.class->devnode = coproc_devnode;
                                ^
cc1: all warnings being treated as errors
What did you build this against?  It has to be be against my
driver-core-next tree as that is where the Fixes: commit is.

thanks,

greg k-h
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help