Re: [PATCH] macintosh/mac_hid.c: don't load by default
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Date: 2022-11-14 18:33:40
Also in:
linux-input, lkml
Hi Thomas, On Sun, Nov 13, 2022 at 04:30:22AM +0100, Thomas Weißschuh wrote:
There should be no need to automatically load this driver on *all* machines with a keyboard. This driver is of very limited utility and has to be enabled by the user explicitly anyway. Furthermore its own header comment has deprecated it for 17 years.
I think if someone does not need a driver they can either not enable it or blacklist it in /etc/modprobe.d/... There is no need to break module loading in the kernel.
quoted hunk ↗ jump to hunk
Fixes: 99b089c3c38a ("Input: Mac button emulation - implement as an input filter") Signed-off-by: Thomas Weißschuh <linux@weissschuh.net> --- drivers/macintosh/mac_hid.c | 2 -- 1 file changed, 2 deletions(-)diff --git a/drivers/macintosh/mac_hid.c b/drivers/macintosh/mac_hid.c index d8c4d5664145..d01d28890db4 100644 --- a/drivers/macintosh/mac_hid.c +++ b/drivers/macintosh/mac_hid.c@@ -149,8 +149,6 @@ static const struct input_device_id mac_hid_emumouse_ids[] = { { }, }; -MODULE_DEVICE_TABLE(input, mac_hid_emumouse_ids); - static struct input_handler mac_hid_emumouse_handler = { .filter = mac_hid_emumouse_filter, .connect = mac_hid_emumouse_connect,base-commit: fef7fd48922d11b22620e19f9c9101647bfe943d -- 2.38.1
Thanks. -- Dmitry