RE: [PATCH v4 2/3] powerpc/pseries: PLPKS SED Opal keystore support
From: Elliott, Robert (Servers) <hidden>
Date: 2022-10-07 19:11:02
Also in:
keyrings, linux-block, linux-efi
quoted hunk ↗ jump to hunk
-----Original Message----- From: gjoyce@linux.vnet.ibm.com <redacted> Sent: Friday, August 19, 2022 5:32 PM To: linux-block@vger.kernel.org Cc: linuxppc-dev@lists.ozlabs.org; jonathan.derrick@linux.dev; brking@linux.vnet.ibm.com; msuchanek@suse.de; mpe@ellerman.id.au; nayna@linux.ibm.com; axboe@kernel.dk; akpm@linux-foundation.org; gjoyce@linux.vnet.ibm.com; linux-efi@vger.kernel.org; keyrings@vger.kernel.org; dhowells@redhat.com; jarkko@kernel.org Subject: [PATCH v4 2/3] powerpc/pseries: PLPKS SED Opal keystore support+++ b/arch/powerpc/platforms/pseries/plpks_sed_ops.c
...
+struct plpks_sed_object_data {
+ u_char version;
+ u_char pad1[7];
+ u_long authority;
+ u_long range;
+ u_int key_len;
+ u_char key[32];
+};...
+/*
+ * Read the SED Opal key from PLPKS given the label
+ */
+int sed_read_key(char *keyname, char *key, u_int *keylen)
+{...
+ *keylen = be32_to_cpu(data->key_len);
+
+ if (var.data) {
+ memcpy(key, var.data + offset, var.datalen - offset);
+ key[*keylen] = '\0';Is there a guarantee that key_len is always < sizeof key, or does that need to be checked in more places?