Thread (26 messages) 26 messages, 4 authors, 2022-10-12

Re: [PATCH v4 12/16] objtool: Read special sections with alts only when specific options are selected

From: Christophe Leroy <hidden>
Date: 2022-10-02 17:42:18
Also in: lkml


Le 02/10/2022 à 12:42, Sathvika Vasireddy a écrit :
Call add_special_section_alts() only when stackval or orc or uaccess or
noinstr options are passed to objtool.

Signed-off-by: Sathvika Vasireddy <redacted>
Reviewed-by: Christophe Leroy <redacted>
quoted hunk ↗ jump to hunk
---
  tools/objtool/check.c | 8 +++++---
  1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/tools/objtool/check.c b/tools/objtool/check.c
index 35827e6c6df9..c6457dac6d58 100644
--- a/tools/objtool/check.c
+++ b/tools/objtool/check.c
@@ -2372,9 +2372,11 @@ static int decode_sections(struct objtool_file *file)
  	 * Must be before add_jump_destinations(), which depends on 'func'
  	 * being set for alternatives, to enable proper sibling call detection.
  	 */
-	ret = add_special_section_alts(file);
-	if (ret)
-		return ret;
+	if (opts.stackval || opts.orc || opts.uaccess || opts.noinstr) {
+		ret = add_special_section_alts(file);
+		if (ret)
+			return ret;
+	}
  
  	ret = add_jump_destinations(file);
  	if (ret)
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help