Thread (7 messages) 7 messages, 4 authors, 2022-10-04

Re: [PATCH V2 2/3] tools/perf/tests: Fix branch stack sampling test to include sanity check for branch filter

From: Michael Ellerman <mpe@ellerman.id.au>
Date: 2022-09-29 05:35:42
Also in: linux-perf-users

Arnaldo Carvalho de Melo [off-list ref] writes:
Em Wed, Sep 21, 2022 at 08:22:54PM +0530, Athira Rajeev escreveu:
quoted
commit b55878c90ab9 ("perf test: Add test for branch stack sampling")
added test for branch stack sampling. There is a sanity check in the
beginning to skip the test if the hardware doesn't support branch stack
sampling.

Snippet
<<>>
skip the test if the hardware doesn't support branch stack sampling
perf record -b -o- -B true > /dev/null 2>&1 || exit 2
<<>>

But the testcase also uses branch sample types: save_type, any. if any
platform doesn't support the branch filters used in the test, the testcase
will fail. In powerpc, currently mutliple branch filters are not supported
and hence this test fails in powerpc. Fix the sanity check to look at
the support for branch filters used in this test before proceeding with
quoted
the test.
Applied the tools/perf/ part
Thanks, I have the other two queued.

cheers
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help