Re: [PATCH v2 37/44] arm,omap2: Use WFI for omap2_pm_idle()

From
Tony Lindgren <tony@atomide.com>
Date
2022-09-27 06:22:06
Also in
linux-acpi, linux-alpha, linux-arch, linux-arm-msm, linux-clk, linux-m68k, linux-mips, linux-omap, linux-perf-users, linux-pm, linux-riscv, linux-s390, linux-sh, linux-tegra, linux-um, lkml, loongarch, sparclinux
Reply to
Peter Zijlstra, 2022-09-19
* Peter Zijlstra [off-list ref] [220919 10:09]:
arch_cpu_idle() is a very simple idle interface and exposes only a
single idle state and is expected to not require RCU and not do any
tracing/instrumentation.

As such, omap2_pm_idle() is not a valid implementation. Replace it
with a simple (shallow) omap2_do_wfi() call.

Omap2 doesn't have a cpuidle driver; but adding one would be the
recourse to (re)gain the other idle states.
Looks good to me thanks:

Acked-by: Tony Lindgren <tony@atomide.com>
Thread (88 messages) 88 messages, 13 authors, last reply 2022-11-22
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help