Re: [PATCH v2 11/16] objtool: Add --mnop as an option to --mcount
From: Naveen N. Rao <hidden>
Date: 2022-09-05 10:56:27
Also in:
lkml
From: Naveen N. Rao <hidden>
Date: 2022-09-05 10:56:27
Also in:
lkml
Peter Zijlstra wrote:
On Mon, Aug 29, 2022 at 11:22:18AM +0530, Sathvika Vasireddy wrote:quoted
Architectures can select HAVE_NOP_MCOUNT if they choose to nop out mcount call sites. If that config option is selected, then --mnop is passed as an option to objtool, along with --mcount. Also, make sure that --mnop can be passed as an option to objtool only when --mcount is passed. Signed-off-by: Sathvika Vasireddy <redacted>IIRC you want to nop the things yourself because PLT entries or something?
For two reasons: 1. We want to maintain a pointer to 'struct module' as part of the ftrace rec so that we can patch ftrace sites in modules to go to module stubs. 2. We depend on compiler generated long branches to support large kernels.
Anyway, patch looks fine, even though the Changelog doesn't relaly justify the change.
Sure. We should add that powerpc kernel does not support nop'ed out ftrace locations.
Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Thanks, Naveen