Hi!
On Fri, Sep 02, 2022 at 09:11:48AM -0700, Nathan Chancellor wrote:
quoted hunk ↗ jump to hunk
On Fri, Sep 02, 2022 at 10:59:54AM -0500, Segher Boessenkool wrote:
quoted
Maybe add -Wno-implicit-fallthrough? This code is a copy from outside
the kernel, no one has ever wanted to maintain it, if nothing else (the
more politically correct formulation is "we cannot as easily pick up
improvements from upstream if we modify stuff").
Sure, we could do something like this if you preferred:
diff --git a/arch/powerpc/math-emu/Makefile b/arch/powerpc/math-emu/Makefile
index 26fef2e5672e..ed775747a2a5 100644
--- a/arch/powerpc/math-emu/Makefile
+++ b/arch/powerpc/math-emu/Makefile
@@ -16,3 +16,7 @@ obj-$(CONFIG_SPE) += math_efp.o
CFLAGS_fabs.o = -fno-builtin-fabs
CFLAGS_math.o = -fno-builtin-fabs
+
+ifdef CONFIG_CC_IS_CLANG
+ccflags-remove-y := $(CONFIG_CC_IMPLICIT_FALLTHROUGH)
+endif
That is a GCC warning as well. It needs some $(call cc-option ...)
thing then, though (GCC versions of more than two or so years ago are
supported as well).
At the same time, I see other modifications to these files that appear
to be for the kernel only so I suspect that this is already in the "we
cannot as easily pick up improvements from upstream" category,
regardless of that diff.
So maybe someone should really maintain this stuff, bring it up to some
reasonably modern state? :-)
Segher