Re: [RFC PATCH RESEND 03/28] mm: introduce __find_vma to be used without... | linuxppc-dev

[RFC PATCH RESEND 00/28] per-VMA locks proposal · Suren Baghdasaryan <surenb@google.com> · 2022-09-01
[RFC PATCH RESEND 02/28] mm: rcu safe VMA freeing · Suren Baghdasaryan <surenb@google.com> · 2022-09-01
[RFC PATCH RESEND 01/28] mm: introduce CONFIG_PER_VMA_LOCK · Suren Baghdasaryan <surenb@google.com> · 2022-09-01
[RFC PATCH RESEND 03/28] mm: introduce __find_vma to be used without mmap_lock protection · Suren Baghdasaryan <surenb@google.com> · 2022-09-01
Re: [RFC PATCH RESEND 03/28] mm: introduce __find_vma to be used without mmap_lock protection · Kent Overstreet <kent.overstreet@linux.dev> · 2022-09-01
Re: [RFC PATCH RESEND 03/28] mm: introduce __find_vma to be used without mmap_lock protection · Suren Baghdasaryan <surenb@google.com> · 2022-09-01
[RFC PATCH RESEND 04/28] mm: move mmap_lock assert function definitions · Suren Baghdasaryan <surenb@google.com> · 2022-09-01
Re: [RFC PATCH RESEND 04/28] mm: move mmap_lock assert function definitions · Kent Overstreet <kent.overstreet@linux.dev> · 2022-09-01
Re: [RFC PATCH RESEND 04/28] mm: move mmap_lock assert function definitions · Liam Howlett <hidden> · 2022-09-01
Re: [RFC PATCH RESEND 04/28] mm: move mmap_lock assert function definitions · Suren Baghdasaryan <surenb@google.com> · 2022-09-01
Re: [RFC PATCH RESEND 04/28] mm: move mmap_lock assert function definitions · Sebastian Andrzej Siewior <bigeasy@linutronix.de> · 2022-09-02
Re: [RFC PATCH RESEND 04/28] mm: move mmap_lock assert function definitions · Suren Baghdasaryan <surenb@google.com> · 2022-09-02
[RFC PATCH RESEND 05/28] mm: add per-VMA lock and helper functions to control it · Suren Baghdasaryan <surenb@google.com> · 2022-09-01
Re: [RFC PATCH RESEND 05/28] mm: add per-VMA lock and helper functions to control it · Laurent Dufour <hidden> · 2022-09-06
Re: [RFC PATCH RESEND 05/28] mm: add per-VMA lock and helper functions to control it · Suren Baghdasaryan <surenb@google.com> · 2022-09-06
[RFC PATCH RESEND 06/28] mm: mark VMA as locked whenever vma->vm_flags are modified · Suren Baghdasaryan <surenb@google.com> · 2022-09-01
Re: [RFC PATCH RESEND 06/28] mm: mark VMA as locked whenever vma->vm_flags are modified · Laurent Dufour <hidden> · 2022-09-06
Re: [RFC PATCH RESEND 06/28] mm: mark VMA as locked whenever vma->vm_flags are modified · Suren Baghdasaryan <surenb@google.com> · 2022-09-06
Re: [RFC PATCH RESEND 06/28] mm: mark VMA as locked whenever vma->vm_flags are modified · Liam Howlett <hidden> · 2022-09-06
Re: [RFC PATCH RESEND 06/28] mm: mark VMA as locked whenever vma->vm_flags are modified · Suren Baghdasaryan <surenb@google.com> · 2022-09-06
[RFC PATCH RESEND 07/28] kernel/fork: mark VMAs as locked before copying pages during fork · Suren Baghdasaryan <surenb@google.com> · 2022-09-01
Re: [RFC PATCH RESEND 07/28] kernel/fork: mark VMAs as locked before copying pages during fork · Laurent Dufour <hidden> · 2022-09-06
Re: [RFC PATCH RESEND 07/28] kernel/fork: mark VMAs as locked before copying pages during fork · Suren Baghdasaryan <surenb@google.com> · 2022-09-08
Re: [RFC PATCH RESEND 07/28] kernel/fork: mark VMAs as locked before copying pages during fork · Laurent Dufour <hidden> · 2022-09-09
Re: [RFC PATCH RESEND 07/28] kernel/fork: mark VMAs as locked before copying pages during fork · Suren Baghdasaryan <surenb@google.com> · 2022-09-09
[RFC PATCH RESEND 08/28] mm/khugepaged: mark VMA as locked while collapsing a hugepage · Suren Baghdasaryan <surenb@google.com> · 2022-09-01
Re: [RFC PATCH RESEND 08/28] mm/khugepaged: mark VMA as locked while collapsing a hugepage · Laurent Dufour <hidden> · 2022-09-06
Re: [RFC PATCH RESEND 08/28] mm/khugepaged: mark VMA as locked while collapsing a hugepage · Suren Baghdasaryan <surenb@google.com> · 2022-09-09
[RFC PATCH RESEND 09/28] mm/mempolicy: mark VMA as locked when changing protection policy · Suren Baghdasaryan <surenb@google.com> · 2022-09-01
Re: [RFC PATCH RESEND 09/28] mm/mempolicy: mark VMA as locked when changing protection policy · Laurent Dufour <hidden> · 2022-09-06
Re: [RFC PATCH RESEND 09/28] mm/mempolicy: mark VMA as locked when changing protection policy · Suren Baghdasaryan <surenb@google.com> · 2022-09-09
[RFC PATCH RESEND 10/28] mm/mmap: mark VMAs as locked in vma_adjust · Suren Baghdasaryan <surenb@google.com> · 2022-09-01
Re: [RFC PATCH RESEND 10/28] mm/mmap: mark VMAs as locked in vma_adjust · Laurent Dufour <hidden> · 2022-09-06
Re: [RFC PATCH RESEND 10/28] mm/mmap: mark VMAs as locked in vma_adjust · Suren Baghdasaryan <surenb@google.com> · 2022-09-09
Re: [RFC PATCH RESEND 10/28] mm/mmap: mark VMAs as locked in vma_adjust · Laurent Dufour <hidden> · 2022-09-09
[RFC PATCH RESEND 11/28] mm/mmap: mark VMAs as locked before merging or splitting them · Suren Baghdasaryan <surenb@google.com> · 2022-09-01
Re: [RFC PATCH RESEND 11/28] mm/mmap: mark VMAs as locked before merging or splitting them · Laurent Dufour <hidden> · 2022-09-06
[RFC PATCH RESEND 12/28] mm/mremap: mark VMA as locked while remapping it to a new address range · Suren Baghdasaryan <surenb@google.com> · 2022-09-01
Re: [RFC PATCH RESEND 12/28] mm/mremap: mark VMA as locked while remapping it to a new address range · Laurent Dufour <hidden> · 2022-09-06
[RFC PATCH RESEND 13/28] mm: conditionally mark VMA as locked in free_pgtables and unmap_page_range · Suren Baghdasaryan <surenb@google.com> · 2022-09-01
Re: [RFC PATCH RESEND 13/28] mm: conditionally mark VMA as locked in free_pgtables and unmap_page_range · Laurent Dufour <hidden> · 2022-09-09
Re: [RFC PATCH RESEND 13/28] mm: conditionally mark VMA as locked in free_pgtables and unmap_page_range · Suren Baghdasaryan <surenb@google.com> · 2022-09-09
[RFC PATCH RESEND 14/28] mm: mark VMAs as locked before isolating them · Suren Baghdasaryan <surenb@google.com> · 2022-09-01
Re: [RFC PATCH RESEND 14/28] mm: mark VMAs as locked before isolating them · Laurent Dufour <hidden> · 2022-09-09
Re: [RFC PATCH RESEND 14/28] mm: mark VMAs as locked before isolating them · Suren Baghdasaryan <surenb@google.com> · 2022-09-09
[RFC PATCH RESEND 15/28] mm/mmap: mark adjacent VMAs as locked if they can grow into unmapped area · Suren Baghdasaryan <surenb@google.com> · 2022-09-01
Re: [RFC PATCH RESEND 15/28] mm/mmap: mark adjacent VMAs as locked if they can grow into unmapped area · Laurent Dufour <hidden> · 2022-09-09
Re: [RFC PATCH RESEND 15/28] mm/mmap: mark adjacent VMAs as locked if they can grow into unmapped area · Suren Baghdasaryan <surenb@google.com> · 2022-09-09
[RFC PATCH RESEND 16/28] kernel/fork: assert no VMA readers during its destruction · Suren Baghdasaryan <surenb@google.com> · 2022-09-01
Re: [RFC PATCH RESEND 16/28] kernel/fork: assert no VMA readers during its destruction · Laurent Dufour <hidden> · 2022-09-09
Re: [RFC PATCH RESEND 16/28] kernel/fork: assert no VMA readers during its destruction · Suren Baghdasaryan <surenb@google.com> · 2022-09-09
[RFC PATCH RESEND 17/28] mm/mmap: prevent pagefault handler from racing with mmu_notifier registration · Suren Baghdasaryan <surenb@google.com> · 2022-09-01
Re: [RFC PATCH RESEND 17/28] mm/mmap: prevent pagefault handler from racing with mmu_notifier registration · Laurent Dufour <hidden> · 2022-09-09
Re: [RFC PATCH RESEND 17/28] mm/mmap: prevent pagefault handler from racing with mmu_notifier registration · Suren Baghdasaryan <surenb@google.com> · 2022-09-09
[RFC PATCH RESEND 18/28] mm: add FAULT_FLAG_VMA_LOCK flag · Suren Baghdasaryan <surenb@google.com> · 2022-09-01
Re: [RFC PATCH RESEND 18/28] mm: add FAULT_FLAG_VMA_LOCK flag · Laurent Dufour <hidden> · 2022-09-09
[RFC PATCH RESEND 19/28] mm: disallow do_swap_page to handle page faults under VMA lock · Suren Baghdasaryan <surenb@google.com> · 2022-09-01
Re: [RFC PATCH RESEND 19/28] mm: disallow do_swap_page to handle page faults under VMA lock · Peter Xu <peterx@redhat.com> · 2022-09-06
Re: [RFC PATCH RESEND 19/28] mm: disallow do_swap_page to handle page faults under VMA lock · Suren Baghdasaryan <surenb@google.com> · 2022-09-06
Re: [RFC PATCH RESEND 19/28] mm: disallow do_swap_page to handle page faults under VMA lock · Peter Xu <peterx@redhat.com> · 2022-09-06
Re: [RFC PATCH RESEND 19/28] mm: disallow do_swap_page to handle page faults under VMA lock · Suren Baghdasaryan <surenb@google.com> · 2022-09-07
Re: [RFC PATCH RESEND 19/28] mm: disallow do_swap_page to handle page faults under VMA lock · Laurent Dufour <hidden> · 2022-09-09
[RFC PATCH RESEND 20/28] mm: introduce per-VMA lock statistics · Suren Baghdasaryan <surenb@google.com> · 2022-09-01
Re: [RFC PATCH RESEND 20/28] mm: introduce per-VMA lock statistics · Laurent Dufour <hidden> · 2022-09-09
Re: [RFC PATCH RESEND 20/28] mm: introduce per-VMA lock statistics · Suren Baghdasaryan <surenb@google.com> · 2022-09-09
[RFC PATCH RESEND 21/28] mm: introduce find_and_lock_anon_vma to be used from arch-specific code · Suren Baghdasaryan <surenb@google.com> · 2022-09-01
Re: [RFC PATCH RESEND 21/28] mm: introduce find_and_lock_anon_vma to be used from arch-specific code · Laurent Dufour <hidden> · 2022-09-09
Re: [RFC PATCH RESEND 21/28] mm: introduce find_and_lock_anon_vma to be used from arch-specific code · Suren Baghdasaryan <surenb@google.com> · 2022-09-09
[RFC PATCH RESEND 22/28] x86/mm: try VMA lock-based page fault handling first · Suren Baghdasaryan <surenb@google.com> · 2022-09-01
[RFC PATCH RESEND 23/28] x86/mm: define ARCH_SUPPORTS_PER_VMA_LOCK · Suren Baghdasaryan <surenb@google.com> · 2022-09-01
Re: [RFC PATCH RESEND 23/28] x86/mm: define ARCH_SUPPORTS_PER_VMA_LOCK · Kent Overstreet <kent.overstreet@linux.dev> · 2022-09-01
Re: [RFC PATCH RESEND 23/28] x86/mm: define ARCH_SUPPORTS_PER_VMA_LOCK · Suren Baghdasaryan <surenb@google.com> · 2022-09-01
[RFC PATCH RESEND 24/28] arm64/mm: try VMA lock-based page fault handling first · Suren Baghdasaryan <surenb@google.com> · 2022-09-01
[RFC PATCH RESEND 25/28] arm64/mm: define ARCH_SUPPORTS_PER_VMA_LOCK · Suren Baghdasaryan <surenb@google.com> · 2022-09-01
[RFC PATCH RESEND 26/28] powerc/mm: try VMA lock-based page fault handling first · Suren Baghdasaryan <surenb@google.com> · 2022-09-01
[RFC PATCH RESEND 28/28] kernel/fork: throttle call_rcu() calls in vm_area_free · Suren Baghdasaryan <surenb@google.com> · 2022-09-01
Re: [RFC PATCH RESEND 28/28] kernel/fork: throttle call_rcu() calls in vm_area_free · Laurent Dufour <hidden> · 2022-09-09
Re: [RFC PATCH RESEND 28/28] kernel/fork: throttle call_rcu() calls in vm_area_free · Suren Baghdasaryan <surenb@google.com> · 2022-09-09
Re: [RFC PATCH RESEND 28/28] kernel/fork: throttle call_rcu() calls in vm_area_free · Laurent Dufour <hidden> · 2022-09-09
[RFC PATCH RESEND 27/28] powerpc/mm: define ARCH_SUPPORTS_PER_VMA_LOCK · Suren Baghdasaryan <surenb@google.com> · 2022-09-01
Re: [RFC PATCH RESEND 00/28] per-VMA locks proposal · Kent Overstreet <kent.overstreet@linux.dev> · 2022-09-01
Re: [RFC PATCH RESEND 00/28] per-VMA locks proposal · Suren Baghdasaryan <surenb@google.com> · 2022-09-01
Re: [RFC PATCH RESEND 00/28] per-VMA locks proposal · Vlastimil Babka <hidden> · 2022-09-11
Re: [RFC PATCH RESEND 00/28] per-VMA locks proposal · Suren Baghdasaryan <surenb@google.com> · 2022-09-28
Re: [RFC PATCH RESEND 00/28] per-VMA locks proposal · Vlastimil Babka <hidden> · 2022-09-29
Re: [RFC PATCH RESEND 00/28] per-VMA locks proposal · Peter Zijlstra <peterz@infradead.org> · 2022-09-02
Re: [RFC PATCH RESEND 00/28] per-VMA locks proposal · Suren Baghdasaryan <surenb@google.com> · 2022-09-02
Re: [RFC PATCH RESEND 00/28] per-VMA locks proposal · Michal Hocko <mhocko@suse.com> · 2022-09-05
Re: [RFC PATCH RESEND 00/28] per-VMA locks proposal · Suren Baghdasaryan <surenb@google.com> · 2022-09-05
Re: [RFC PATCH RESEND 00/28] per-VMA locks proposal · Kent Overstreet <kent.overstreet@linux.dev> · 2022-09-05
Re: [RFC PATCH RESEND 00/28] per-VMA locks proposal · Suren Baghdasaryan <surenb@google.com> · 2022-09-06

Re: [RFC PATCH RESEND 03/28] mm: introduce __find_vma to be used without mmap_lock protection

From: Suren Baghdasaryan <surenb@google.com>
Date: 2022-09-01 23:18:43
Also in: linux-arm-kernel, linux-mm, lkml

On Thu, Sep 1, 2022 at 1:22 PM Kent Overstreet
[off-list ref] wrote:

On Thu, Sep 01, 2022 at 10:34:51AM -0700, Suren Baghdasaryan wrote:

quoted

Add __find_vma function to be used for VMA lookup under rcu protection.

So it was news to me that the rb tree code can be used for lockless lookups -
not having looked at lib/rbtree.c in over 10 years :) - I still think it should
be mentioned in the commit message that that's what you're doing and why it's
safe, because it's not exactly common knowledge and lockless stuff deserves
extra scrutiny.

Probably worth a comment, too.

Ack.

Reviewed-by: Kent Overstreet <kent.overstreet@linux.dev>

Thanks!

--
To unsubscribe from this group and stop receiving emails from it, send an email to kernel-team+unsubscribe@android.com.

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help