Re: [PATCH v4 3/8] dt-bindings: clock: Add ids for Lynx 10g PLLs

On 05/08/2022 17:17, Sean Anderson wrote:

On 8/5/22 2:53 AM, Krzysztof Kozlowski wrote:

quoted

On 05/08/2022 00:05, Sean Anderson wrote:

quoted

This adds ids for the Lynx 10g SerDes's internal PLLs. These may be used
witn assigned-clock* to specify a particular frequency to use.

Signed-off-by: Sean Anderson <redacted>
---

Changes in v4:
- New

 include/dt-bindings/clock/fsl,lynx-10g.h | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
 create mode 100644 include/dt-bindings/clock/fsl,lynx-10g.h

diff --git a/include/dt-bindings/clock/fsl,lynx-10g.h b/include/dt-bindings/clock/fsl,lynx-10g.h
new file mode 100644
index 000000000000..f5b955658106
--- /dev/null
+++ b/include/dt-bindings/clock/fsl,lynx-10g.h

@@ -0,0 +1,14 @@
+/* SPDX-License-Identifier: GPL-2.0-only */

This should be dual license.

This is just matching what the majority (263 out of 326) clock dt-bindings headers do.

Then please license it just like bindings, so dual license with BSD.

quoted

quoted

+/*
+ * Copyright (C) 2022 Sean Anderson [off-list ref]

It's confusing to see personal copyrights with company email. Either the
copyright is attributed to your employer or to you. If to you, use
private email.

I hold the copyright, and I would like inquiries to be directed to my work
email (as I don't have this hardware at home).

OK, I guess I won't be the only one confused :). This entry here is not
parsed for any tools and only sometimes people look at it. The questions
are directed via entry in maintainers file or via git history, so you
can put company email just there.

quoted

quoted

+ */
+
+#ifndef __DT_BINDINGS_CLK_LYNX_10G_H
+#define __DT_BINDINGS_CLK_LYNX_10G_H
+
+#define LYNX10G_CLKS_PER_PLL 2
+
+#define LYNX10G_PLLa(a)		((a) * LYNX10G_CLKS_PER_PLL)
+#define LYNX10G_PLLa_EX_DLY(a)	((a) * LYNX10G_CLKS_PER_PLL + 1)

These do not look like proper IDs for clocks for bindings. Numbering
starts from 0 or 1 and any "a" needs to be clearly explained. What do
you bind here?

This matches "a" is the index of the PLL. E.g. registers PLL1RSTCTL etc.
This matches the notation used in the reference manual.

This is a file for bindings, not for storing register values. There is
no single need to store register values (offsets, indexes) as bindings
as it is not appropriate. Therefore if you do not use it as an ID, just
remove the bindings header.

Although for
convenience, this driver considers the PLLs to start at 0 instead of 1.

Best regards,
Krzysztof