Thread (2 messages) 2 messages, 2 authors, 2022-08-31

Re: [PATCH] cpuidle: move from strlcpy with unused retval to strscpy

From: "Rafael J. Wysocki" <rafael@kernel.org>
Date: 2022-08-31 19:11:19
Also in: linux-pm, lkml

On Thu, Aug 18, 2022 at 11:00 PM Wolfram Sang
[off-list ref] wrote:
quoted hunk ↗ jump to hunk
Follow the advice of the below link and prefer 'strscpy' in this
subsystem. Conversion is 1:1 because the return value is not used.
Generated by a coccinelle script.

Link: https://lore.kernel.org/r/CAHk-=wgfRnXz0W3D37d01q3JFkr_i_uTL=V6A6G1oUZcprmknw@mail.gmail.com/ (local)
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
 drivers/cpuidle/cpuidle-powernv.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/cpuidle/cpuidle-powernv.c b/drivers/cpuidle/cpuidle-powernv.c
index c32c600b3cf8..0b5461b3d7dd 100644
--- a/drivers/cpuidle/cpuidle-powernv.c
+++ b/drivers/cpuidle/cpuidle-powernv.c
@@ -233,8 +233,8 @@ static inline void add_powernv_state(int index, const char *name,
                                     unsigned int exit_latency,
                                     u64 psscr_val, u64 psscr_mask)
 {
-       strlcpy(powernv_states[index].name, name, CPUIDLE_NAME_LEN);
-       strlcpy(powernv_states[index].desc, name, CPUIDLE_NAME_LEN);
+       strscpy(powernv_states[index].name, name, CPUIDLE_NAME_LEN);
+       strscpy(powernv_states[index].desc, name, CPUIDLE_NAME_LEN);
        powernv_states[index].flags = flags;
        powernv_states[index].target_residency = target_residency;
        powernv_states[index].exit_latency = exit_latency;
--
Applied as 6.1 material, thanks!
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help