Le 08/08/2022 à 13:48, Sathvika Vasireddy a écrit :
objtool is throwing *unannotated intra-function call*
warnings with a few instructions that are marked
unreachable. Replace unreachable() with __builtin_unreachable()
to fix these warnings, as the codegen remains same
with unreachable() and __builtin_unreachable().
I think it is necessary to explain why using unreachable() is not
necessary for powerpc, or even why using unreachable() is wrong.
Allthough we are getting rid of the problem here by replacing
unreachable() by __builtin_unreachable(), it might still be a problem in
core parts of kernel which still use unreachable.
So maybe it would be better to leave that as is, and instead modify
annotate_unreachable() so that only architectures requiring it
absolutely get it. For instance by defining and using a new config item,
for instance CONFIG_OBJTOOL_NEEDS_ANNOTATE_UNREACHABLE
quoted hunk ↗ jump to hunk
Signed-off-by: Sathvika Vasireddy <redacted>
---
arch/powerpc/include/asm/bug.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/include/asm/bug.h b/arch/powerpc/include/asm/bug.h
index 61a4736355c2..074be1a78c56 100644
--- a/arch/powerpc/include/asm/bug.h
+++ b/arch/powerpc/include/asm/bug.h
@@ -99,7 +99,7 @@
__label__ __label_warn_on; \
\
WARN_ENTRY("twi 31, 0, 0", BUGFLAG_WARNING | (flags), __label_warn_on); \
- unreachable(); \
+ __builtin_unreachable(); \
\
__label_warn_on: \
break; \