Re: [PATCH v2 02/10] drm/simpledrm: Inline device-init helpers

Hello Thomas,

On 7/20/22 16:27, Thomas Zimmermann wrote:

Inline the helpers for initializing the hardware FB, the memory
management and the modesetting into the device-creation function.
No functional changes.

Could you please elaborate in the commit message why this change is
desirable?  Without this additional context, this feels like going
backwards, since you are dropping few helpers that have quite self
contained code and making simpledrm_device_create() much larger.

-- 
Best regards,

Javier Martinez Canillas
Linux Engineering
Red Hat