Re: [PATCH v1 1/5] powerpc/32: Do not allow selection of e5500 or e6500 CPUs on PPC32
From: Christophe Leroy <hidden>
Date: 2022-07-11 17:42:16
Also in:
lkml
From: Christophe Leroy <hidden>
Date: 2022-07-11 17:42:16
Also in:
lkml
Le 11/07/2022 à 18:39, Segher Boessenkool a écrit :
Hi! On Mon, Jul 11, 2022 at 04:19:29PM +0200, Christophe Leroy wrote:quoted
Commit 0e00a8c9fd92 ("powerpc: Allow CPU selection also on PPC32") enlarged the CPU selection logic to PPC32 by removing depend to PPC64, and failed to restrict that depend to E5500_CPU and E6500_CPU. Fortunately that got unnoticed because -mcpu=8540 will override the -mcpu=e500mc64 or -mpcu=e6500 as they are ealier, but that's fragile and may no be right in the future.A later -mcpu= always overrides an earlier one. This is the same as with all other GCC option flags, and will not change in the future.
By "future" I meant after patch 2. At the time being, if you select PPC32 and MPC_85xx and E6500_CPU, you get -mcpu=e6500 -mcpu=8540. After patch 2, if you select PPC32 and MPC_85xx and E6500_CPU, you get -mcpu=e6500 Christophe