Thread (20 messages) 20 messages, 3 authors, 2023-04-12

Re: [Bug 216095] New: sysfs: cannot create duplicate filename '/devices/platform/of-display'

From: Michael Ellerman <mpe@ellerman.id.au>
Date: 2022-06-14 14:01:47
Subsystem: open firmware and flattened device tree, the rest · Maintainers: Rob Herring, Saravana Kannan, Linus Torvalds

Hi Erhard,

This is presumably caused by:

  52b1b46c39ae ("of: Create platform devices for OF framebuffers")

Can you try the patch below?

cheers

diff --git a/drivers/of/platform.c b/drivers/of/platform.c
index 3507095a69f6..a70ff9df5cb9 100644
--- a/drivers/of/platform.c
+++ b/drivers/of/platform.c
@@ -556,7 +556,7 @@ static int __init of_platform_default_populate_init(void)
 			if (!of_get_property(node, "linux,opened", NULL) ||
 			    !of_get_property(node, "linux,boot-display", NULL))
 				continue;
-			dev = of_platform_device_create(node, "of-display", NULL);
+			dev = of_platform_device_create(node, NULL, NULL);
 			if (WARN_ON(!dev))
 				return -ENOMEM;
 			boot_display = node;
@@ -565,7 +565,7 @@ static int __init of_platform_default_populate_init(void)
 		for_each_node_by_type(node, "display") {
 			if (!of_get_property(node, "linux,opened", NULL) || node == boot_display)
 				continue;
-			of_platform_device_create(node, "of-display", NULL);
+			of_platform_device_create(node, NULL, NULL);
 		}
 
 	} else {

bugzilla-daemon@kernel.org writes:
https://bugzilla.kernel.org/show_bug.cgi?id=216095

            Bug ID: 216095
           Summary: sysfs: cannot create duplicate filename
                    '/devices/platform/of-display'
           Product: Platform Specific/Hardware
           Version: 2.5
    Kernel Version: 5.19-rc1
          Hardware: PPC-32
                OS: Linux
              Tree: Mainline
            Status: NEW
          Severity: normal
          Priority: P1
         Component: PPC-32
          Assignee: platform_ppc-32@kernel-bugs.osdl.org
          Reporter: erhard_f@mailbox.org
        Regression: No

Created attachment 301127
  --> https://bugzilla.kernel.org/attachment.cgi?id=301127&action=edit
dmesg (5.19-rc1, PowerMac G4 DP)

[...]
sysfs: cannot create duplicate filename '/devices/platform/of-display'
CPU: 0 PID: 1 Comm: swapper/0 Not tainted 5.19.0-rc1-PMacG4+ #3
Call Trace:
[e9025cc0] [c05984d0] dump_stack_lvl+0x60/0x90 (unreliable)
[e9025ce0] [c02f043c] sysfs_warn_dup+0x64/0x84
[e9025d00] [c02f05cc] sysfs_create_dir_ns+0xfc/0x118
[e9025d30] [c059ffa4] kobject_add_internal+0x114/0x2f0
[e9025d60] [c05a0790] kobject_add+0x80/0xf0
[e9025da0] [c064c3d8] device_add+0x114/0x94c
[e9025e10] [c06f197c] of_platform_device_create_pdata+0xb8/0x144
[e9025e40] [c0c43bb4] of_platform_default_populate_init+0x284/0x2f4
[e9025e70] [c0007a94] do_one_initcall+0x50/0x294
[e9025ee0] [c0c03ff0] kernel_init_freeable+0x228/0x334
[e9025f20] [c0007efc] kernel_init+0x28/0x144
[e9025f40] [c0019334] ret_from_kernel_thread+0x5c/0x64
kobject_add_internal failed for of-display with -EEXIST, don't try to register
things with the same name in the same directory.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help