[PATCH] tty: serial: Fix refcount leak bug in ucc_uart.c
From: Liang He <hidden>
Date: 2022-06-18 06:10:35
Also in:
linux-serial, lkml
Subsystem:
freescale quicc engine ucc uart driver, the rest, tty layer and serial drivers · Maintainers:
Timur Tabi, Linus Torvalds, Greg Kroah-Hartman, Jiri Slaby
In soc_info(), of_find_node_by_type() will return a node pointer with refcount incremented. We should use of_node_put() when it is not used anymore. Signed-off-by: Liang He <redacted> --- drivers/tty/serial/ucc_uart.c | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/drivers/tty/serial/ucc_uart.c b/drivers/tty/serial/ucc_uart.c
index 6000853973c1..3cc9ef08455c 100644
--- a/drivers/tty/serial/ucc_uart.c
+++ b/drivers/tty/serial/ucc_uart.c@@ -1137,6 +1137,8 @@ static unsigned int soc_info(unsigned int *rev_h, unsigned int *rev_l) /* No compatible property, so try the name. */ soc_string = np->name; + of_node_put(np); + /* Extract the SOC number from the "PowerPC," string */ if ((sscanf(soc_string, "PowerPC,%u", &soc) != 1) || !soc) return 0;
--
2.25.1