Re: [FSL P50x0] Keyboard and mouse don't work anymore after the devicetree updates for 5.19
From: Christian Zigotzky <hidden>
Date: 2022-05-30 05:27:13
On 27 May 2022 at 04:23 pm, Rob Herring wrote:
quoted hunk ↗ jump to hunk
The issue is in drivers/usb/host/fsl-mph-dr-of.c which copies the resources to a child platform device. Can you try the following change:diff --git a/drivers/usb/host/fsl-mph-dr-of.c b/drivers/usb/host/fsl-mph-dr-of.c index 44a7e58a26e3..47d9b7be60da 100644 --- a/drivers/usb/host/fsl-mph-dr-of.c +++ b/drivers/usb/host/fsl-mph-dr-of.c@@ -80,8 +80,6 @@ static struct platform_device *fsl_usb2_device_register( const char *name, int id) { struct platform_device *pdev; - const struct resource *res = ofdev->resource; - unsigned int num = ofdev->num_resources; int retval; pdev = platform_device_alloc(name, id);@@ -106,11 +104,7 @@ static struct platform_device *fsl_usb2_device_register( if (retval) goto error; - if (num) { - retval = platform_device_add_resources(pdev, res, num); - if (retval) - goto error; - } + pdev->dev.of_node = ofdev->dev.of_node; retval = platform_device_add(pdev); if (retval)
Hello Rob, Thanks a lot for your patch! Unfortunately, this leads to a boot loop. Do you have another idea? Thanks, Christian