Re: [PATCH] ASoC: fsl_xcvr:Fix unbalanced pm_runtime_enable in fsl_xcvr_probe
From: Shengjiu Wang <shengjiu.wang@gmail.com>
Date: 2022-05-27 09:52:49
Also in:
alsa-devel
On Thu, May 26, 2022 at 9:18 AM zhangqilong [off-list ref] wrote:
quoted hunk ↗ jump to hunk
Add missing pm_runtime_disable() when probe error out. It could avoid pm_runtime implementation complains when removing and probing again the driver. Fix:c590fa80b3928 ("ASoC: fsl_xcvr: register platform component before registering cpu dai") Signed-off-by: Zhang Qilong <redacted> --- sound/soc/fsl/fsl_xcvr.c | 2 ++ 1 file changed, 2 insertions(+)diff --git a/sound/soc/fsl/fsl_xcvr.c b/sound/soc/fsl/fsl_xcvr.c index d0556c79fdb1..907435efe121 100644 --- a/sound/soc/fsl/fsl_xcvr.c +++ b/sound/soc/fsl/fsl_xcvr.c@@ -1228,6 +1228,7 @@ static int fsl_xcvr_probe(struct platform_device*pdev) */ ret = devm_snd_dmaengine_pcm_register(dev, NULL, 0); if (ret) { + pm_runtime_disable(dev); dev_err(dev, "failed to pcm register\n"); return ret; }@@ -1235,6 +1236,7 @@ static int fsl_xcvr_probe(struct platform_device*pdev) ret = devm_snd_soc_register_component(dev, &fsl_xcvr_comp, &fsl_xcvr_dai, 1); if (ret) { + pm_runtime_disable(dev); dev_err(dev, "failed to register component %s\n", fsl_xcvr_comp.name); } Could you please also help add remove() function and add
pm_runtime_disable() in the remove()? Thanks. best regards wang shengjiu