Thread (7 messages) 7 messages, 4 authors, 2022-05-24

Re: [PATCH 1/2] powerpc: Add generic PAGE_SIZE config symbols

From: Christophe Leroy <hidden>
Date: 2022-05-18 13:29:29
Also in: lkml


Le 18/05/2022 à 15:21, Arnd Bergmann a écrit :
On Wed, May 18, 2022 at 2:00 PM Michael Ellerman [off-list ref] wrote:
quoted
Christophe Leroy [off-list ref] writes:
quoted
Le 05/05/2022 à 14:51, Michael Ellerman a écrit :
quoted
Other arches (sh, mips, hexagon) use standard names for PAGE_SIZE
related config symbols.

Add matching symbols for powerpc, which are enabled by default but
depend on our architecture specific PAGE_SIZE symbols.

This allows generic/driver code to express dependencies on the PAGE_SIZE
without needing to refer to architecture specific config symbols.
I guess next step should be to get rid of powerpc specific symbols and
use generic symbols instead.

We have (only) 111 occurences of it.
I thought about doing that, but it's quite a bit of churn. Maybe it's
worth it though to avoid confusion between the two symbols.
I have actually done this at some point, but for some reason never sent it out,
see my old patch at:

https://git.kernel.org/pub/scm/linux/kernel/git/arnd/playground.git/commit/?h=randconfig-5.15-next&id=184c7273ee367fda3626e35f0079f181075690c8

Feel free to take ideas or the entire patch from that.

Well, at this point I was just talking about renaming the 
CONFIG_PPC_xxK_PAGES symbols to the generic naming while still keeping 
them in powerpc Kconfig.

You are going one step further by making it a generic arch symbol, 
that's also a good idea and can be done more or less independantly.

Christophe
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help