Re: [PATCH] selftests/powerpc/pmu: Fix unsigned function returning negative constant
From: kajoljain <hidden>
Date: 2022-04-26 06:31:19
Also in:
linux-kselftest, lkml
On 4/24/22 13:56, Haowen Bai wrote:
quoted hunk ↗ jump to hunk
The function __perf_reg_mask has an unsigned return type, but returns a negative constant to indicate an error condition. So we change unsigned to int. Signed-off-by: Haowen Bai <redacted> --- tools/testing/selftests/powerpc/pmu/sampling_tests/misc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/tools/testing/selftests/powerpc/pmu/sampling_tests/misc.c b/tools/testing/selftests/powerpc/pmu/sampling_tests/misc.c index fca054bbc094..c01a31d5f4ee 100644 --- a/tools/testing/selftests/powerpc/pmu/sampling_tests/misc.c +++ b/tools/testing/selftests/powerpc/pmu/sampling_tests/misc.c@@ -274,7 +274,7 @@ u64 *get_intr_regs(struct event *event, void *sample_buff) return intr_regs; } -static const unsigned int __perf_reg_mask(const char *register_name) +static const int __perf_reg_mask(const char *register_name) {
Hi Haowen, Thanks for correcting it. Can you also add fix tag with corresponding commit id details. Other than that patch looks good to me. Reviewed-by: Kajol Jain<redacted> Thanks, Kajol Jain
if (!strcmp(register_name, "R0")) return 0;