Re: [PATCH 01/22] orion5x: Replace comments with C99 initializers
From: Daniel Thompson <hidden>
Date: 2022-03-28 13:17:45
Also in:
linux-acpi, linux-edac, linux-gpio, linux-input, linux-media, linux-pci, linux-rdma, linux-samsung-soc, linux-wireless, lkml, netdev
On Sat, Mar 26, 2022 at 05:58:48PM +0100, Benjamin Stürz wrote:
This replaces comments with C99's designated initializers because the kernel supports them now.
This commit description seems wrong to me. This patch doesn't include use C99 designated initializers (or AFAICT any other language feature that has recently been enabled in the kernel). The changes here are just plain constant-expressions in enumeration lists and were included in C89/C90. Daniel.
quoted hunk ↗ jump to hunk
Signed-off-by: Benjamin Stürz <redacted> --- arch/arm/mach-orion5x/dns323-setup.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)diff --git a/arch/arm/mach-orion5x/dns323-setup.c b/arch/arm/mach-orion5x/dns323-setup.c index 87cb47220e82..d762248c6512 100644 --- a/arch/arm/mach-orion5x/dns323-setup.c +++ b/arch/arm/mach-orion5x/dns323-setup.c@@ -61,9 +61,9 @@ /* Exposed to userspace, do not change */ enum { - DNS323_REV_A1, /* 0 */ - DNS323_REV_B1, /* 1 */ - DNS323_REV_C1, /* 2 */ + DNS323_REV_A1 = 0, + DNS323_REV_B1 = 1, + DNS323_REV_C1 = 2, };-- 2.35.1