Thread (9 messages) 9 messages, 4 authors, 2022-03-12

Re: [PATCH] powerpc: 8xx: fix a return value error in mpc8xx_pic_init

From: Hangyu Hua <hidden>
Date: 2022-03-07 01:41:53
Also in: lkml

Ping?

On 2022/2/23 15:02, Hangyu Hua wrote:
quoted hunk ↗ jump to hunk
mpc8xx_pic_init() should return -ENOMEM instead of 0 when
irq_domain_add_linear() return NULL. This cause mpc8xx_pics_init to continue
executing even if mpc8xx_pic_host is NULL.

Fixes: cc76404feaed ("powerpc/8xx: Fix possible device node reference leak")
Signed-off-by: Hangyu Hua <redacted>
---
  arch/powerpc/platforms/8xx/pic.c | 1 +
  1 file changed, 1 insertion(+)
diff --git a/arch/powerpc/platforms/8xx/pic.c b/arch/powerpc/platforms/8xx/pic.c
index f2ba837249d6..04a6abf14c29 100644
--- a/arch/powerpc/platforms/8xx/pic.c
+++ b/arch/powerpc/platforms/8xx/pic.c
@@ -153,6 +153,7 @@ int __init mpc8xx_pic_init(void)
  	if (mpc8xx_pic_host == NULL) {
  		printk(KERN_ERR "MPC8xx PIC: failed to allocate irq host!\n");
  		ret = -ENOMEM;
+		goto out;
  	}
  
  	ret = 0;
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help