[PATCH] powerpc: kernel: fix a refcount leak in format_show()

From
Hangyu Hua <hidden>
Date
2022-02-28 09:11:31
Also in
lkml
node needs to be dropped when of_property_read_string fails. So an earlier call
to of_node_put is required here.

Signed-off-by: Hangyu Hua <redacted>
---
 arch/powerpc/kernel/secvar-sysfs.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/arch/powerpc/kernel/secvar-sysfs.c b/arch/powerpc/kernel/secvar-sysfs.c
index a0a78aba2083..cd0fa7028d86 100644
--- a/arch/powerpc/kernel/secvar-sysfs.c
+++ b/arch/powerpc/kernel/secvar-sysfs.c
@@ -30,13 +30,12 @@ static ssize_t format_show(struct kobject *kobj, struct kobj_attribute *attr,
 		return -ENODEV;
 
 	rc = of_property_read_string(node, "format", &format);
+	of_node_put(node);
 	if (rc)
 		return rc;
 
 	rc = sprintf(buf, "%s\n", format);
 
-	of_node_put(node);
-
 	return rc;
 }
 
-- 
2.25.1
Thread (4 messages) 4 messages, 3 authors, last reply 2022-03-02
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help