Re: [PATCH v4] powerpc/mce: Avoid using irq_work_queue() in realmode
From: kernel test robot <hidden>
Date: 2022-01-18 11:16:25
Also in:
oe-kbuild-all
Hi Ganesh, Thank you for the patch! Yet something to improve: [auto build test ERROR on powerpc/next] [also build test ERROR on v5.16 next-20220118] [cannot apply to scottwood/next mpe/next] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Ganesh-Goudar/powerpc-mce-Avoid-using-irq_work_queue-in-realmode/20220117-163425 base: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next config: powerpc64-randconfig-c024-20220116 (https://download.01.org/0day-ci/archive/20220118/202201181831.VB3r6wzz-lkp@intel.com/config) compiler: powerpc64-linux-gcc (GCC) 11.2.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/bb8f4e786eb9c838daad7a6187dcd59040ff2771 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Ganesh-Goudar/powerpc-mce-Avoid-using-irq_work_queue-in-realmode/20220117-163425 git checkout bb8f4e786eb9c838daad7a6187dcd59040ff2771 # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=powerpc SHELL=/bin/bash arch/powerpc/platforms/pseries/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <redacted> All errors (new ones prefixed by >>): arch/powerpc/platforms/pseries/ras.c: In function 'mce_handle_error':
quoted
arch/powerpc/platforms/pseries/ras.c:715:23: error: unused variable 'msr' [-Werror=unused-variable]
715 | unsigned long msr;
| ^~~
cc1: all warnings being treated as errors
vim +/msr +715 arch/powerpc/platforms/pseries/ras.c
a43c1590426c44 Mahesh Salgaonkar 2018-09-11 709
4ff753feab0212 Ganesh Goudar 2020-07-24 710 static int mce_handle_error(struct pt_regs *regs, struct rtas_error_log *errp)
4ff753feab0212 Ganesh Goudar 2020-07-24 711 {
4ff753feab0212 Ganesh Goudar 2020-07-24 712 struct pseries_errorlog *pseries_log;
4ff753feab0212 Ganesh Goudar 2020-07-24 713 struct pseries_mc_errorlog *mce_log = NULL;
4ff753feab0212 Ganesh Goudar 2020-07-24 714 int disposition = rtas_error_disposition(errp);
74c3354bc1d89d Nicholas Piggin 2021-02-07 @715 unsigned long msr;
4ff753feab0212 Ganesh Goudar 2020-07-24 716 u8 error_type;
4ff753feab0212 Ganesh Goudar 2020-07-24 717
4ff753feab0212 Ganesh Goudar 2020-07-24 718 if (!rtas_error_extended(errp))
4ff753feab0212 Ganesh Goudar 2020-07-24 719 goto out;
4ff753feab0212 Ganesh Goudar 2020-07-24 720
4ff753feab0212 Ganesh Goudar 2020-07-24 721 pseries_log = get_pseries_errorlog(errp, PSERIES_ELOG_SECT_ID_MCE);
4ff753feab0212 Ganesh Goudar 2020-07-24 722 if (!pseries_log)
4ff753feab0212 Ganesh Goudar 2020-07-24 723 goto out;
4ff753feab0212 Ganesh Goudar 2020-07-24 724
4ff753feab0212 Ganesh Goudar 2020-07-24 725 mce_log = (struct pseries_mc_errorlog *)pseries_log->data;
4ff753feab0212 Ganesh Goudar 2020-07-24 726 error_type = mce_log->error_type;
4ff753feab0212 Ganesh Goudar 2020-07-24 727
4ff753feab0212 Ganesh Goudar 2020-07-24 728 disposition = mce_handle_err_realmode(disposition, error_type);
4ff753feab0212 Ganesh Goudar 2020-07-24 729 out:
4ff753feab0212 Ganesh Goudar 2020-07-24 730 disposition = mce_handle_err_virtmode(regs, errp, mce_log,
4ff753feab0212 Ganesh Goudar 2020-07-24 731 disposition);
9ca766f9891d23 Nicholas Piggin 2019-08-02 732 return disposition;
7f177f9810ada8 Ganesh Goudar 2019-04-15 733 }
7f177f9810ada8 Ganesh Goudar 2019-04-15 734
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org