Thread (6 messages) 6 messages, 3 authors, 2022-01-06

Re: [PATCH V2 1/2] tools/perf: Include global and local variants for p_stage_cyc sort key

From: Arnaldo Carvalho de Melo <acme@kernel.org>
Date: 2022-01-06 20:23:10
Also in: linux-perf-users

Em Thu, Jan 06, 2022 at 04:21:05PM +0530, Athira Rajeev escreveu:
quoted
On 08-Dec-2021, at 9:21 AM, Nageswara Sastry [off-list ref] wrote:



On 07/12/21 8:22 pm, Arnaldo Carvalho de Melo wrote:
quoted
Em Fri, Dec 03, 2021 at 07:50:37AM +0530, Athira Rajeev escreveu:
quoted
Sort key p_stage_cyc is used to present the latency
cycles spend in pipeline stages. perf tool has local
p_stage_cyc sort key to display this info. There is no
global variant available for this sort key. local variant
shows latency in a sinlge sample, whereas, global value
will be useful to present the total latency (sum of
latencies) in the hist entry. It represents latency
number multiplied by the number of samples.

Add global (p_stage_cyc) and local variant
(local_p_stage_cyc) for this sort key. Use the
local_p_stage_cyc as default option for "mem" sort mode.
Also add this to list of dynamic sort keys and made the
"dynamic_headers" and "arch_specific_sort_keys" as static.

Signed-off-by: Athira Rajeev <redacted>
Reported-by: Namhyung Kim <namhyung@kernel.org>
I got this for v1, does it stand for v2?
Tested-by: Nageswara R Sastry <redacted>

Tested with v2 also.
Hi Arnaldo,

If this patchset looks fine to you, can you please consider pulling it.
Thanks, applied to perf/core, for 5.17.

- Arnaldo
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help