Re: [PATCH 3/6] KVM: Remove opaque from kvm_arch_check_processor_compat
From: Sean Christopherson <seanjc@google.com>
Date: 2022-01-12 17:21:45
Also in:
kvm, kvm-riscv, kvmarm, linux-mips, linux-riscv, linux-s390, lkml
On Wed, Jan 12, 2022, Sean Christopherson wrote:
On Tue, Jan 11, 2022, Chao Gao wrote:quoted
On Mon, Jan 10, 2022 at 11:06:44PM +0000, Sean Christopherson wrote:quoted
On Mon, Dec 27, 2021, Chao Gao wrote:quoted
No arch implementation uses this opaque now.Except for the RISC-V part, this can be a pure revert of commit b99040853738 ("KVM: Pass kvm_init()'s opaque param to additional arch funcs"). I think it makes sense to process it as a revert, with a short blurb in the changelog to note that RISC-V is manually modified as RISC-V support came along in the interim.commit b99040853738 adds opaque param to kvm_arch_hardware_setup(), which isn't reverted in this patch. I.e., this patch is a partial revert of b99040853738 plus manual changes to RISC-V. Given that, "process it as a revert" means clearly say in changelog that this commit contains a partial revert of commit b99040853738 ("KVM: Pass kvm_init()'s opaque param to additional arch funcs"). Right?What I meant is literally do git revert -s b99040853738 and then manually handle RISC-V.
Doh, to be clear, "manually handle RISC-V _in the same commit_".