Thread (6 messages) flat view 6 messages, 4 authors, 2021-12-15

Re: [PATCH] powerpc/module_64: Fix livepatching for RO modules

From: Joe Lawrence <joe.lawrence@redhat.com>
Date: 2021-12-10 03:10:22
Also in: live-patching

On 12/9/21 2:00 AM, Michael Ellerman wrote:
Russell Currey [off-list ref] writes:
quoted
On Tue, 2021-12-07 at 09:44 -0500, Joe Lawrence wrote:
quoted
On 11/23/21 3:15 AM, Russell Currey wrote:

[[ cc += livepatching list ]]

Hi Russell,

Thanks for writing a minimal fix for stable / backporting.  As I
mentioned on the github issue [1], this avoided the crashes I
reported
here and over on kpatch github [2].  I wasn't sure if this is the
final
version for stable, but feel free to add my:

Tested-by: Joe Lawrence <joe.lawrence@redhat.com>
Thanks Joe, as per the discussions on GitHub I think we're fine to use
this patch for a fix for stable (unless there's new issues found or
additional community feedback etc).
Hmm, I read the GitHub discussion as being that you were going to do
another version, which is why I haven't picked this up. But I guess you
and Christophe were talking about the non-minimal fix.

I know we want this to be minimal, but I think it should be checking
that patch_instruction() isn't failing.

Incremental diff to do that is below. It boots OK, are you able to throw
a livepatch test at it?
No problem.  The incremental patch update tests successful.

Thanks,

-- 
Joe
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help