Thread (27 messages) 27 messages, 7 authors, 2021-12-18

Re: [PATCH v1 0/5] Implement livepatch on PPC32

From: Steven Rostedt <rostedt@goodmis.org>
Date: 2021-12-14 14:01:55
Also in: linux-s390, live-patching, lkml

On Tue, 14 Dec 2021 08:35:14 +0100
Christophe Leroy [off-list ref] wrote:
quoted
Will continue investigating.
  
trace_selftest_startup_function_graph() calls register_ftrace_direct() 
which returns -ENOSUPP because powerpc doesn't select 
CONFIG_DYNAMIC_FTRACE_WITH_DIRECT_CALLS.

Should TEST_DIRECT_TRAMP depend on CONFIG_DYNAMIC_FTRACE_WITH_DIRECT_CALLS ?
Yes, that should be:

#if defined(CONFIG_DYNAMIC_FTRACE) && \
    defined(CONFIG_HAVE_DYNAMIC_FTRACE_WITH_DIRECT_CALLS)
#define TEST_DIRECT_TRAMP
noinline __noclone static void trace_direct_tramp(void) { }
#endif


And make it test it with or without the args.

Thanks for finding this.

-- Steve
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help