Thread (2 messages) flat view 2 messages, 2 authors, 2021-12-20

RE: [PATCH] sound: fsl: add missing put_device() call in imx_hdmi_probe()

From: 王擎 <hidden>
Date: 2021-12-09 09:58:58
Also in: alsa-devel, lkml

quoted
From: Wang Qing <redacted>

of_find_device_by_node() takes a reference to the embedded struct device 
which needs to be dropped when error return.
...
quoted
       data = devm_kzalloc(&pdev->dev, sizeof(*data), GFP_KERNEL);
       if (!data) {
+             put_device(&cpu_pdev->dev);
If it's of_find_device_by_node() you need an of_node_put() since you're
dropping a reference on the OF node.
Label fail will drop a reference on the OF node.
Also, put_device() is called later except this branch, 
we just need to add put_device() here.

Thanks,
Qing
quoted
               ret = -ENOMEM;
                goto fail;
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help