Thread (2 messages) flat view 2 messages, 2 authors, 2021-12-08

Re: [PATCH] sound: fsl: add missing put_device() call in imx_hdmi_probe()

From: Mark Brown <broonie@kernel.org>
Date: 2021-12-08 14:05:15
Also in: alsa-devel, linux-arm-kernel, lkml

On Tue, Dec 07, 2021 at 04:56:58AM -0800, Qing Wang wrote:
From: Wang Qing <redacted>

of_find_device_by_node() takes a reference to the embedded struct device 
which needs to be dropped when error return.
...
 	data = devm_kzalloc(&pdev->dev, sizeof(*data), GFP_KERNEL);
 	if (!data) {
+		put_device(&cpu_pdev->dev);
If it's of_find_device_by_node() you need an of_node_put() since you're
dropping a reference on the OF node.

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help