Thread (5 messages) flat view 5 messages, 5 authors, 2021-12-15

Re: [PATCH] powerpc: platforms: cell: pervasive: fix clang -Wimplicit-fallthrough

From: Arnd Bergmann <arnd@arndb.de>
Date: 2021-12-07 13:01:02
Also in: lkml, llvm

On Tue, Dec 7, 2021 at 12:02 PM Anders Roxell [off-list ref] wrote:
Clang warns:

arch/powerpc/platforms/cell/pervasive.c:81:2: error: unannotated fall-through between switch labels [-Werror,-Wimplicit-fallthrough]
        case SRR1_WAKEEE:
        ^
arch/powerpc/platforms/cell/pervasive.c:81:2: note: insert 'break;' to avoid fall-through
        case SRR1_WAKEEE:
        ^
        break;
1 error generated.

Clang is more pedantic than GCC, which does not warn when failing
through to a case that is just break or return. Clang's version
is more in line with the kernel's own stance in deprecated.rst.
Add athe missing break to silence the warning.

Fixes: 6e83985b0f6e ("powerpc/cbe: Do not process external or decremeter interrupts from sreset")
Reported-by: Naresh Kamboju <redacted>
Signed-off-by: Anders Roxell <redacted>
Thanks for the fix!

Reviewed-by: Arnd Bergmann <arnd@arndb.de>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help