Re: [PATCH v2 5/5] powerpc/watchdog: Remove backtrace print from unstuck message

From
Nicholas Piggin <npiggin@gmail.com>
Date
2021-11-05 01:29:23
Reply to
Laurent Dufour, 2021-11-04
Excerpts from Laurent Dufour's message of November 5, 2021 2:48 am:
Le 04/11/2021 à 17:10, Nicholas Piggin a écrit :
quoted
The watchdog unstuck message can't be serialised with other watchdog
messages because that might prevent watchdog reporting. This removes
the big backtrace from the unstuck message, which can get mixed with
other messages and confuse logs, and just prints a single line.
I'm not sure that's a good idea to remove the registers and backtrace here.
I agree that this output may interleaved (and usually it does), but it is also 
providing some good information about the culprit block of code. Usually, it's 
pointing the IRQ release code, and so the IRQ blocking one which are really useful.
Okay, I was thinking that be inferred from the context usually, but 
sometimes it's not that easy which I guess is why I added it in the
first place.
I don't have a good way to prevent trace interleaving here, but I think 
interleaved traces are better here than nothing.
Okay we can leave this patch off.

Thanks,
Nick
Thread (13 messages) 13 messages, 2 authors, last reply 2021-11-05
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help