On Tue, Nov 2, 2021 at 5:10 PM Luis Chamberlain [off-list ref] wrote:

On Fri, Oct 15, 2021 at 05:13:48PM -0700, Dan Williams wrote:

quoted

On Fri, Oct 15, 2021 at 4:53 PM Luis Chamberlain [off-list ref] wrote:

quoted

If nd_integrity_init() fails we'd get del_gendisk() called,
but that's not correct as we should only call that if we're
done with device_add_disk(). Fix this by providing unwinding
prior to the devm call being registered and moving the devm
registration to the very end.

This should fix calling del_gendisk() if nd_integrity_init()
fails. I only spotted this issue through code inspection. It
does not fix any real world bug.

Just fyi, I'm preparing patches to delete this driver completely as it
is unused by any shipping platform. I hope to get that removal into
v5.16.

Curious if are you going to nuking it on v5.16? Otherwise it would stand
in the way of the last few patches to add __must_check for the final
add_disk() error handling changes.

True, I don't think I can get it nuked in time, so you can add my
Reviewed-by for this one.