Re: [V3] powerpc/perf: Enable PMU counters post partition migration if PMU is active
From: kernel test robot <hidden>
Date: 2021-10-29 10:22:39
Also in:
oe-kbuild-all
Hi Athira, Thank you for the patch! Yet something to improve: [auto build test ERROR on powerpc/next] [also build test ERROR on tip/perf/core v5.15-rc7 next-20211028] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Athira-Rajeev/powerpc-perf-Enable-PMU-counters-post-partition-migration-if-PMU-is-active/20211029-110804 base: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next config: powerpc64-randconfig-r003-20211028 (attached as .config) compiler: powerpc64-linux-gcc (GCC) 11.2.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/caeb6bb8d2f36e6b15151587193c1e0a9e62ab16 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Athira-Rajeev/powerpc-perf-Enable-PMU-counters-post-partition-migration-if-PMU-is-active/20211029-110804 git checkout caeb6bb8d2f36e6b15151587193c1e0a9e62ab16 # save the attached .config to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=powerpc SHELL=/bin/bash arch/powerpc/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <redacted> All errors (new ones prefixed by >>): arch/powerpc/platforms/pseries/mobility.c: In function 'pseries_migrate_partition':
quoted
arch/powerpc/platforms/pseries/mobility.c:670:22: error: 'mobility_pmu_disable' undeclared (first use in this function)
670 | on_each_cpu(&mobility_pmu_disable, NULL, 0);
| ^~~~~~~~~~~~~~~~~~~~
arch/powerpc/platforms/pseries/mobility.c:670:22: note: each undeclared identifier is reported only once for each function it appears inquoted
arch/powerpc/platforms/pseries/mobility.c:679:22: error: 'mobility_pmu_enable' undeclared (first use in this function)
679 | on_each_cpu(&mobility_pmu_enable, NULL, 0);
| ^~~~~~~~~~~~~~~~~~~
vim +/mobility_pmu_disable +670 arch/powerpc/platforms/pseries/mobility.c
660
661 static int pseries_migrate_partition(u64 handle)
662 {
663 int ret;
664
665 ret = wait_for_vasi_session_suspending(handle);
666 if (ret)
667 return ret;
668
669 /* Disable PMU before suspend */
> 670 on_each_cpu(&mobility_pmu_disable, NULL, 0);
671
672 ret = pseries_suspend(handle);
673 if (ret == 0)
674 post_mobility_fixup();
675 else
676 pseries_cancel_migration(handle, ret);
677
678 /* Enable PMU after resuming */
> 679 on_each_cpu(&mobility_pmu_enable, NULL, 0);
680
681 return ret;
682 }
683
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Attachments
- .config.gz [application/gzip] 36333 bytes